Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: update create app docs and the app example, as well as add with_projects to ListApps #733

Merged
merged 7 commits into from
Nov 1, 2022

Conversation

ghostlandr
Copy link
Contributor

We just added project_id as a parameter to the CreateApp RPC, so this PR updates the documentation to reflect that. project_id also comes back on the newly created App so that's documented now too.

@ghostlandr
Copy link
Contributor Author

This relates to the changes here digitalocean/godo#572

kamaln7
kamaln7 previously approved these changes Oct 26, 2022
specification/resources/apps/models/app.yml Outdated Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I left a couple small suggestions in line.

specification/resources/apps/models/app.yml Outdated Show resolved Hide resolved
Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
@ghostlandr ghostlandr changed the title apps: update create app docs and the app example apps: update create app docs and the app example, as well as add with_projects to ListApps Nov 1, 2022
@ghostlandr
Copy link
Contributor Author

New in this branch, the with_projects param here
image

@ChiefMateStarbuck ChiefMateStarbuck merged commit 025bf98 into digitalocean:main Nov 1, 2022
@ghostlandr ghostlandr deleted the add-project-id branch November 1, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants