-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps: update create app docs and the app example, as well as add with_projects to ListApps #733
Merged
ChiefMateStarbuck
merged 7 commits into
digitalocean:main
from
ghostlandr:add-project-id
Nov 1, 2022
Merged
apps: update create app docs and the app example, as well as add with_projects to ListApps #733
ChiefMateStarbuck
merged 7 commits into
digitalocean:main
from
ghostlandr:add-project-id
Nov 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relates to the changes here digitalocean/godo#572 |
kamaln7
previously approved these changes
Oct 26, 2022
Co-authored-by: Kamal Nasser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I left a couple small suggestions in line.
specification/resources/apps/models/apps_create_app_request.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
andrewsomething
previously approved these changes
Oct 28, 2022
…ocean#732) Co-authored-by: lhenry <[email protected]>
…OM (digitalocean#735) Co-authored-by: Daniel Weinshenker <[email protected]>
ghostlandr
changed the title
apps: update create app docs and the app example
apps: update create app docs and the app example, as well as add with_projects to ListApps
Nov 1, 2022
ChiefMateStarbuck
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just added project_id as a parameter to the CreateApp RPC, so this PR updates the documentation to reflect that. project_id also comes back on the newly created App so that's documented now too.