Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Uptime Checks and Alerts Support #593

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Add Uptime Checks and Alerts Support #593

merged 4 commits into from
Jan 17, 2023

Conversation

danaelhe
Copy link
Member

@danaelhe danaelhe commented Jan 9, 2023

Adding Uptime Checks and Alerts support to godo (api doc here). Adding to terraform-digitalocean-provider next.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few suggestions in line.

uptime.go Outdated Show resolved Hide resolved
uptime.go Outdated Show resolved Hide resolved
uptime.go Outdated Show resolved Hide resolved
uptime.go Outdated Show resolved Hide resolved
uptime.go Outdated Show resolved Hide resolved
uptime.go Outdated Show resolved Hide resolved
uptime.go Outdated Show resolved Hide resolved
uptime.go Outdated Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@danaelhe danaelhe merged commit 0d12938 into main Jan 17, 2023
@danaelhe danaelhe deleted the add_alerts_checks branch January 17, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants