Adds support for functions trigger API #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyush0101
reviewed
Nov 21, 2022
functions.go
Outdated
| } | ||
|
|
||
| type FunctionsTriggerUpdateRequest struct { | ||
| IsEnabled bool `json:"is_enabled"` |
There was a problem hiding this comment.
Should this be a pointer? Do we support updating scheduled_details without sending is_enabled? Does the API differentiate between not sending is_enabled and sending is_enabled: false? Without making this a pointer, Go will default to setting this false if excluded.
There was a problem hiding this comment.
Thanks Andrew, yes the API does allow changing scheduled_details without changing is_enabled , I changed the FunctionsTriggerUpdateRequest.IsEnabled to be a *bool.
… go defaulting to false.
…godo into functions-trigger-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.digitalocean.com/reference/api/api-reference/#operation/functions_list_triggers