LBAAS Fixup default http idle timeout behaviour #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenVarela
commented
Nov 11, 2022
| @@ -104,10 +103,6 @@ func (l LoadBalancer) AsRequest() *LoadBalancerRequest { | |||
| r.Region = l.Region.Slug | |||
| } | |||
|
|
|||
| if l.HTTPIdleTimeoutSeconds == nil { | |||
There was a problem hiding this comment.
setting this here https://github.com/digitalocean/godo/pull/580/files#diff-c9b4c15afcc0c5f0ead492bd8e12abb791b72cdd4985919a15f04b7708629281R87 should be sufficient
There was a problem hiding this comment.
@StephenVarela is the diff link supposed to reference a specific line?
There was a problem hiding this comment.
Hrmm thats weird sorry I meant to point to line 88 in this file (load_balancers.go) https://github.com/digitalocean/godo/blob/main/load_balancers.go#L88
There was a problem hiding this comment.
I just understood your wording "setting this here ... should be sufficient" to mean the link was pointing elsewhere since the comment is on removed code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.