Deprecate old pointer helpers, use generic one #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates and changes all of the uses of the various pointer-to style helpers in favour of using a generic one. I've seen more and more of the `*type` struct fields pop up in new features, so I figure this might offer a more consistent way to create a pointer to a type, rather having to use an old type specific one or have users create their own.
bentranter
requested review from
andrewsomething,
scotchneat,
ChiefMateStarbuck and
danaelhe
bentranter
changed the title
ChiefMateStarbuck
approved these changes
Nov 10, 2022
scotchneat
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates and changes all of the uses of the various pointer-to style helpers in favour of using a generic one.
I've seen more and more of the
*typestruct fields pop up in new features, so I figure this might offer a more consistent way to create a pointer to a type, rather having to use an old type specific one or have users create their own.Most of this is PR is changing the use of old test helpers to use the new func. The implementation of the new func here.