Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions api support #577

Merged
merged 6 commits into from
Nov 7, 2022
Merged

Functions api support #577

merged 6 commits into from
Nov 7, 2022

Conversation

ddebarros
Copy link
Contributor

@ddebarros ddebarros commented Nov 3, 2022 •
edited
Loading

Adds support for functions API's which includes

  • Namespaces (List, Get, Create, Delete)

API Reference

@ddebarros ddebarros marked this pull request as ready for review November 4, 2022 19:01
andrewsomething
andrewsomething requested changes Nov 7, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few comments inline that make some of the method and type names a bit more consistent with other services.

functions.go Outdated Show resolved Hide resolved
functions.go Outdated Show resolved Hide resolved
andrewsomething
andrewsomething approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsomething andrewsomething merged commit 13e886a into digitalocean:main Nov 7, 2022
@andrewsomething andrewsomething mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddebarros @andrewsomething