Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-5657 (Re-)expose public HA enablement flags in godo #565

Merged
merged 2 commits into from
Oct 12, 2022
Merged

CON-5657 (Re-)expose public HA enablement flags in godo #565

merged 2 commits into from
Oct 12, 2022

Conversation

dylanrhysscott
Copy link
Contributor

@dylanrhysscott dylanrhysscott commented Oct 12, 2022

Reverts #484 in preparation for HA enablement

@dylanrhysscott dylanrhysscott marked this pull request as ready for review October 12, 2022 12:01
@dylanrhysscott dylanrhysscott changed the title CON-5657 (Re-)expose public HA enablement flags in godo and doctl CON-5657 (Re-)expose public HA enablement flags in godo Oct 12, 2022
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know @andrewsomething said we should put out a beta note somewhere. Not sure if that is to be done in-code or as part of an upcoming release (note) though. Relying on Andrew to provide clarity.

kubernetes.go Outdated Show resolved Hide resolved
@andrewsomething
Copy link
Member

Not sure if that is to be done in-code or as part of an upcoming release (note) though. Relying on Andrew to provide clarity.

A code comment doesn't hurt, but it's something we'll need to remember to come back and clean up. I will add a mention to the release notes. e.g.

https://github.com/digitalocean/godo/releases/tag/v1.74.0

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@andrewsomething andrewsomething merged commit dbd4902 into digitalocean:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants