Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize public protos and add multiple specs #508

Conversation

ElanHasson
Copy link
Contributor

@ElanHasson ElanHasson commented Jan 21, 2022

This synchronizes our public protos with godo and includes several changes:

  • Updates various documentation elements
  • Adds support for AppDomainSpec.Certificate and MinimumTLSVersion
  • Adds support for AppLogDestinationSpecHeader
  • Adds support for AppServiceSpecHealthCheck.Port
  • Adds DeploymentCauseDetailsType.DeploymentCauseDetailsType_UpdateDatabaseTrustedSources
  • Adds DeploymentCauseDetailsDigitalOceanUserActionName.DeploymentCauseDetailsDigitalOceanUserActionName_ResetDatabasePassword, DeploymentCauseDetailsDigitalOceanUserActionName_RollbackApp, DeploymentCauseDetailsDigitalOceanUserActionName_RevertAppRollback
  • Adds support for AppDomainValidation

@ElanHasson ElanHasson force-pushed the APPS-4762-Allow_health_checks_to_specify_port branch from e89aed5 to a21596b Compare January 21, 2022 05:23
@ElanHasson ElanHasson requested a review from kamaln7 January 21, 2022 05:24
@ElanHasson ElanHasson changed the title APPS-4762-Allow health checks to specify a port. APPS-4762-Allow health checks to specify a port and add missing public messages and update comments. Jan 21, 2022
@ElanHasson ElanHasson force-pushed the APPS-4762-Allow_health_checks_to_specify_port branch from 59c2fd8 to fe44931 Compare January 21, 2022 17:19
@ElanHasson ElanHasson changed the title APPS-4762-Allow health checks to specify a port and add missing public messages and update comments. Synchronize public protos and add multiple specs Jan 21, 2022
This synchronizes our public protos with godo and includes several changes:

* Updates various documentation elements
* Adds support for AppDomainSpec.Certificate and MinimumTLSVersion
* Adds support for AppLogDestinationSpecHeader
* Adds support for AppServiceSpecHealthCheck.Port
* Adds DeploymentCauseDetailsType.DeploymentCauseDetailsType_UpdateDatabaseTrustedSources
* Adds DeploymentCauseDetailsDigitalOceanUserActionName.DeploymentCauseDetailsDigitalOceanUserActionName_ResetDatabasePassword, DeploymentCauseDetailsDigitalOceanUserActionName_RollbackApp, DeploymentCauseDetailsDigitalOceanUserActionName_RevertAppRollback
* Adds support for AppDomainValidation
@ElanHasson ElanHasson force-pushed the APPS-4762-Allow_health_checks_to_specify_port branch from fe44931 to d164096 Compare January 21, 2022 17:22
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Thanks @ElanHasson!

@andrewsomething andrewsomething merged commit 4b7fcd3 into digitalocean:main Jan 21, 2022
@ElanHasson ElanHasson deleted the APPS-4762-Allow_health_checks_to_specify_port branch January 21, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants