Add CertificatesService for managing certificates with the DigitalOcean API. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viola
force-pushed
the
add-certificates
branch
from
68caed3
to
befaf62
Compare
mpapi
approved these changes
Feb 17, 2017
certificates.go
Outdated
|
|
||
| // Get an existing certificate by its identifier. | ||
| func (c *CertificatesServiceOp) Get(cID string) (*Certificate, *Response, error) { | ||
| path := fmt.Sprintf("%s/%s", certificatesBasePath, cID) |
There was a problem hiding this comment.
You could use path.Join here as well, from the stdlib (though you'd have to rename the path var so it doesn't clash with the path package).
And for a couple of instances in later methods, too.
Not strictly necessary, but I feel like it's a little more idiomatic and also saves you from accidentally having double slashes.
There was a problem hiding this comment.
@mpapi ty, good idea, will patch that, many thx for your review.
viola
force-pushed
the
add-certificates
branch
from
0015a10
to
566f702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adds support for managing certificates with the DigitalOcean API @ https://developers.digitalocean.com/documentation/v2/#certificates