driver: check volume limit #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes digitalocean/godo#177 which we need to implement volume limit check Updated with the command: ``` dep ensure -update github.com/digitalocean/godo ```
lxfontes
reviewed
Sep 4, 2018
| } | ||
|
|
||
| // administrative accounts might have zero length limits, make sure to not check them | ||
| if account.VolumeLimit == 0 { |
lxfontes
reviewed
Sep 4, 2018
driver/controller.go
Outdated
| return nil // hail to the king! | ||
| } | ||
|
|
||
| volumes, _, err := d.doClient.Storage.ListVolumes(ctx, &godo.ListVolumeParams{ |
There was a problem hiding this comment.
🎗 this is listing volumes by region but the received limit is for all regions.
meaning: this is a best-effort check and won't ever hit in case the user has at least 1 volume in a different region.
the proper fix is for us ( DigitalOcean ) to expose limits per region. it is in the works but no ETA.
There was a problem hiding this comment.
Thanks Lucas, good to know. I added a note to the source code so it's aware to the reader as well: 445ec7a
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31