Use godo action status for handling resize operation #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documented state is now consistently used by the API.
gottwald
approved these changes
Aug 1, 2023
llDrLove
reviewed
Aug 1, 2023
driver/controller.go
Outdated
| @@ -210,7 +207,7 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest) | |||
| "resized_from": int(snapshot.SizeGigaBytes), | |||
| "resized_to": int(volumeReq.SizeGigaBytes), | |||
| }) | |||
| if action != nil && action.Status != doneActionStatus { | |||
| if action != nil && action.Status != godo.ActionCompleted { | |||
There was a problem hiding this comment.
@timoreimann , is this action != nil necessary since we didn't get an error from the .Resize() call ?
Also, here we check for action != nil when we don't do the same check on line 1052.
It's not really related to your PR but if we could make it consistent it would be better IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documented state is now consistently used by the API.