Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-9193 Update sidecars containers for v4.6.1 #502

Merged
merged 3 commits into from
May 17, 2023

Conversation

llDrLove
Copy link
Contributor

Updating deploy/kubernetes/releases/csi-digitalocean-dev folder to the latest sidecar containers and at the same time create a new v4.6.1 release.

@llDrLove llDrLove self-assigned this May 15, 2023
@llDrLove llDrLove requested a review from timoreimann May 16, 2023 12:39
@llDrLove llDrLove marked this pull request as ready for review May 16, 2023 12:48
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two comments, though not blocking.

CHANGELOG.md Outdated
@@ -1,5 +1,9 @@
## unreleased

## v4.6.1 - 2023.05.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 16th by now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed to 17th

@@ -1 +1 @@
v4.6.0
v4.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've never formally defined if we should bump the minor or patch version of the release when we bump just the sidecars. My gut feeling is that when at least one sidecar is bumped on the minor version, then I'd also bump the minor version on our release.

Probably a bit of a grey area, but that's my take.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same but from this table it seems like everything 1.27 related should be under 4.6.x. Thus, I'll keep it that way for now.

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two comments, though not blocking.

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two comments, though not blocking.

@llDrLove llDrLove merged commit 6362cd9 into master May 17, 2023
@llDrLove llDrLove deleted the CON-9193-update-sidecars branch May 17, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants