-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CON-9193 Update sidecars containers for v4.6.1 #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two comments, though not blocking.
CHANGELOG.md
Outdated
@@ -1,5 +1,9 @@ | |||
## unreleased | |||
|
|||
## v4.6.1 - 2023.05.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 16th by now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed to 17th
@@ -1 +1 @@ | |||
v4.6.0 | |||
v4.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've never formally defined if we should bump the minor or patch version of the release when we bump just the sidecars. My gut feeling is that when at least one sidecar is bumped on the minor version, then I'd also bump the minor version on our release.
Probably a bit of a grey area, but that's my take.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same but from this table it seems like everything 1.27 related should be under 4.6.x. Thus, I'll keep it that way for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two comments, though not blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two comments, though not blocking.
Updating
deploy/kubernetes/releases/csi-digitalocean-dev
folder to the latest sidecar containers and at the same time create a new v4.6.1 release.