Support setting DO API rate limit #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
support-godo-rate-limiter
branch
4 times, most recently
from
d6acb10 to
7d03ab0
Compare
timoreimann
force-pushed
the
upgrade-to-go-v1.19
branch
from
81662f9 to
32a3e6b
Compare
timoreimann
force-pushed
the
support-godo-rate-limiter
branch
from
7d03ab0 to
cbc5fb5
Compare
timoreimann
force-pushed
the
support-godo-rate-limiter
branch
from
cbc5fb5 to
05b3863
Compare
dylanrhysscott
approved these changes
Oct 17, 2022
Setting a rate limit can be useful to prevent running out of API quota in case of pathological API usage patterns (e.g., bugs or thrashing with another controller).
timoreimann
force-pushed
the
support-godo-rate-limiter
branch
from
05b3863 to
0c15368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a rate limit can be useful to prevent running out of API quota in case of pathological API usage patterns (e.g., bugs or thrashing with another controller).
Update Go to v1.19 as well because latest godo requires at least 1.18.