driver: check if the mounts are propagated #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure mount propagation is enabled. We can check it by using `findmnt` with the `PROPAGATION` label. Also fix an issue to check the mounted path for the target path where checking against the staging target path won't work as findmnt only works on devices
lxfontes
reviewed
Aug 1, 2018
|
|
||
| // the mountpoint should match as well | ||
| if fs.Target == target { | ||
| targetFound = true |
There was a problem hiding this comment.
return true, nil and get rid of targetFound
There was a problem hiding this comment.
Good call, but we can't do it because there might be two mount points. If the first one is shared and it fits the target, if we early return in this case, we might miss the second one (which could be private for example). However I removed this piece:
if targetFound {
return true, nil
}
return false, nil
to
return targetFound, nil
|
lgtm |
fatih
force-pushed
the
handle-propagation
branch
from
27d2588 to
deda025
Compare
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure mount propagation is enabled. We can check it by using
findmntwith thePROPAGATIONlabel.Also fix an issue to check the mounted path for the target path where
checking against the staging target path won't work as findmnt only
works on devices