-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v1.22 e2e #420
Support v1.22 e2e #420
Conversation
1f3d613
to
d0271cc
Compare
There are some conflicts here. @CollinShoop could it be that your branched off of master in your local checkout as opposed to the |
2748c0d
to
048a179
Compare
I did fork my branch off of |
SupportedSizeRange: | ||
Max: 100Gi | ||
Min: 1Gi | ||
Capabilities: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timoreimann How do I know which Capabilities need to be provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a bit non-trivial, unfortunately: you basically need to know which capabilities are available in CSI (by reading up on the CSI docs and the CSI spec), which of those our driver supports, and then take a good guess or look at the upstream e2e code to understand what the individual capabilities refer to exactly.
In this case, it's relatively easy since the caps don't seem to have changed between 1.21 and 1.22, so we should be fine copying what we have for 1.21 already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh.. I was afraid of that. Guess I got lucky though 😅
Bumped k8s dependencies to 0.22.5
df48c7b
to
a260d85
Compare
@@ -68,5 +68,5 @@ if [[ "${SKIP_SEQUENTIAL_TESTS:-}" ]]; then | |||
echo 'Skipping sequential tests' | |||
else | |||
echo 'Running sequential tests' | |||
ginkgo -v -focus="External.Storage${focus}.*(\[Feature:|\[Serial\])" -skip='\[Disruptive\]' "${E2E_TEST_FILE}" -- "-storage.testdriver=${TD_FILE}" | |||
ginkgo -v -focus="External.Storage${focus}.*(\[Feature:|\[Serial\])" -skip='\[Disruptive\]|\[Feature:VolumeSourceXFS\]' "${E2E_TEST_FILE}" -- "-storage.testdriver=${TD_FILE}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to avoid new tests that were added with 1.22 that are failing but from manual testing would also fail on 1.21.
CON-4800
3.11
->3.15
(optional, just keeping things up date)patch
permissions requirements that were missing (see under breaking changes)[Feature:VolumeSourceXFS]
to avoid problematic tests - this should be removed after 1.22 whenever we have a fix for it.Vendor changes