Update Kubernetes dependency to 1.19.2 and sidecars to latest #341
Conversation
There was a problem hiding this comment.
This looks good. A few remarks / questions:
-
Strictly speaking, we do not need the flag to set ext4 since our driver implementation is already assuming ext4 if no explicit driver is set. Shouldn't make a difference, though less parameters to maintain may seem better.
-
The external-provisioner change log says the following:
Add VolumeAttachment Lister to prevent calling DeleteVolume on the CSI plugin for volumes that are still attached to a kubernetes node. New RBAC rules for listing VolumeAttachment objects are required.
It sounds like we would need to extend the RBAC rules then?
- Similar remark on the csi-attacher change log::
RBAC policy was updated to allow the external-attacher to patch VolumeAttachment.Status.
Could you also add a change log entry? 🙏
|
It also seems like the images are being moved to k8s.gcr.io now. Pulling from Quay still works though, so maybe that's to support a transitioning period. |
|
Ah, I had updated the RBAC rules elsewhere for testing, but forgot to apply those changes here. Added. Also updated the changelog, and got rid of the |
|
Looking good. 👍 The CI is unhappy for what I believe to be reasons unrelated to your PR. (Other open, much more trivial PRs are failing too.) I'm investigating. |
|
CI is green. 🎉 |
|
We may want to bump the Kubernetes deps to 1.19.2 now that it's out, just so that we're on the latest version when this PR merges. |
A couple of changes here other than the image tags: 1. Add `--handle-volume-inuse-error=false` to the resizer, since we handle online resizes. 2. Update RBAC rules for the provisioner and attacher to accommodate newly-required permissions.
timoreimann
changed the title
Update our Kubernetes dependencies to 1.19.2. While we're here, update all the sidecars to their latest versions:
--handle-volume-inuse-error=falsesince we can handle online resizes.