Refactor waitAction #229
Merged
Refactor waitAction #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors waitAction to use wait.PollUntil from the upstream apimachinery library to hide the underlying polling infrastructure and simplify the implementation. We also exit the method if the context got cancelled while waiting for a response from the volume API. Previously, we would iterate through the for loop once again and possibly do another unnecessary API interaction if the ticker was ready again by that time. Finally, we add a unit test (which required making the wait action timeout injectable).
timoreimann
commented
Dec 9, 2019
| defer cancel() | ||
|
|
||
| // TODO(arslan): use backoff in the future |
There was a problem hiding this comment.
Note to reviewers: I did not carry this TODO intentionally since backoffs for timeouts are implemented by the sidecars, and other kinds of errors we occasionally run into do not seem to warrant an exponential backoff as of today (e.g., temporary 4xx responses returned from the API that disappear on the next API call).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors
waitActionto usewait.PollUntilfrom the upstream apimachinery library to hide the underlying polling infrastructure and simplify the implementation.We also exit the method if the context got cancelled while waiting for a response from the volume API. Previously, we would iterate through the for loop once again and possibly do another unnecessary API interaction if the ticker was ready again by that time.
Finally, we add a unit test (which required making the wait action timeout injectable).
The change passes both our local integration and upstream e2e tests.