-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2938: Add translations for chat and danish #2939
base: main
Are you sure you want to change the base?
Conversation
@@ -11,7 +11,8 @@ | |||
"createPdf": "PDF ይፍጠሩ", | |||
"metaDescription": "{{appName}} በጀርመን ላለው ህይወት የእርስዎ ዲጂታል መመሪያ ነው። አካባቢያዊ መረጃን፣ ክንዉኖችን እና ምክርን ያግኙ። በእርስዎ ቋንቋ ሁልጊዜ የቅርብ ጊዜ የሆነ እና የሚገኝ ነው።", | |||
"organizationContent": "የዚህ ገጽ ይዘቶች ከ{{organization}} ናቸው።", | |||
"organizationMoreInformation": "ስለ <1>{{organization}}</1> on <3>{{domain}}</3> ተጨማሪ መረጃ ማግኘት ይችላሉ።" | |||
"organizationMoreInformation": "ስለ <1>{{organization}}</1> on <3>{{domain}}</3> ተጨማሪ መረጃ ማግኘት ይችላሉ።", | |||
"disabledPdf": "/ፒዲኤፍ/pdf ወደ ውጭ መላክ በአሁኑ ጊዜ በዚህ ቋንቋ አይቻልም።" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osmers a few translations in tygrinia seem to be off, for example this one. Could you perhaps double check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steffenkleinle could you define - off? What would you reckon is wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you paste this to google translate, you get:
/pdf/pdf export is currently not possible in this language.
I had some other example where I thought something was wrong but can't find it anymore 🙈
And obviously I meant Amharic, not Tygrinia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steffenkleinle bei Senden und Du wird mir auch was anderes übersetzt...kann natürlich an Google Translate liegen, aber ich frage mal nach.
Ist dir noch bei anderen Sprachen was aufgefallen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ne, ich glaub nur hier. Danke!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steffenkleinle eine Sache ist mir noch eingefallen - alle Übersetzungen in Amharisch sind mit Sie übersetzt, während wir im Deutsch Du schreiben. Stört uns das? Scheint aber auch in den alten Übersetzungen schon so zu sein.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... das ist eher ne Frage für z.B. @dkehne denke ich.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ist auch die Frage, ob es sowas wie Du überhaupt gibt bzw kulturell angebracht ist. Ich würde es jetzt erstmal so lassen, weil wir sonst alle überarbeiten müssten, wollte aber mal drauf hinweisen.
Die anderen Punkte klärt MeinRad bereits mit dem Übersetzer :)
Code Climate has analyzed commit dd612e8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.2%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested
Short description
Add translations for chat and danish.
Proposed changes
Add translations for chat and danish.
Side effects
None.
Testing
Check the constants.
Resolved issues
Fixes: #2938.