use DeviceCodeName for code name and DeviceName for name #7
Conversation
they are actually pretty different in some cases and both have useful information. typical example: Device_Name="Galaxy S5 LTE" Device_Code_Name="SM-G900F"
| } | ||
|
|
||
| func (browser *Browser) IsIPad() bool { | ||
| return browser.Platform == "iOS" && browser.DeviceName == "iPad" | ||
| return browser.Platform == "iOS" && browser.DeviceCodeName == "iPad" |
There was a problem hiding this comment.
typical example:
Device_Name="Galaxy S5 LTE"
Device_Code_Name="SM-G900F"
Shouldn't this line still be:
return browser.Platform == "iOS" && browser.DeviceName == "iPad"
| @@ -214,11 +220,11 @@ func (browser *Browser) IsAndroid() bool { | |||
| } | |||
|
|
|||
| func (browser *Browser) IsIPhone() bool { | |||
| return browser.Platform == "iOS" && browser.DeviceName == "iPhone" | |||
| return browser.Platform == "iOS" && browser.DeviceCodeName == "iPhone" | |||
There was a problem hiding this comment.
Same as below, I think this should still be
return browser.Platform == "iOS" && browser.DeviceName == "iPhone"
There was a problem hiding this comment.
This change is there because browser.DeviceName used to take value from DeviceCodeName line in the INI file (which I believe is wrong and misleading). For iPhone and iPad these lines seem to be the same, but I don't believe it's correct to expect that DeviceName should always match DeviceCodeName since they are technically different things.
There was a problem hiding this comment.
My take is that DeviceName is more semantically accurate here. (I don't think "iPhone" is a code-name anymore :-). ) As you point out, in the current INI file the device-name and device-code-name area always the same for iPhone and iPad, so it doesn't make a difference as far as the code is concerned, it's just which makes more semantic sense.
they are actually pretty different in some cases and both have useful
information.
typical example:
Device_Name="Galaxy S5 LTE"
Device_Code_Name="SM-G900F"