Add support for multiple database instances #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a more concise picture of the full public API, and makes navigating the code a bit easier with the large doc comments.
This adds a `Marker` trait, which just specifies a database `Driver` implementing `sqlx::Database`. APIs now use `Marker` as the bound for `DB` generic type parameters. There is a trivial blanket implementation for all types implementing `sqlx::Database` which makes this backwards compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of "state" in #27 makes me think this is now type-safe enough to be usable.
c0b7a18 refactor: move everything from
libinto separate modulesThis gives a more concise picture of the full public API, and makes
navigating the code a bit easier with the large doc comments.
243fc03 refactor: support multiple databases of the same type
This adds a
Markertrait, which just specifies a databaseDriverimplementing
sqlx::Database. APIs now useMarkeras the bound forDBgeneric type parameters. There is a trivial blanket implementationfor all types implementing
sqlx::Databasewhich makes this backwardscompatible.