improve "patch bazel windows" UX#6764
Merged
garyverhaegen-da merged 1 commit intomasterfrom Sep 30, 2020
Merged
Conversation
garyverhaegen-da
force-pushed
the
patch-windows-bazel-ux
branch
from
fe371a3 to
cddfab0
Compare
Contributor
Author
|
Note: it looks like Azure has upgraded the bundled Bazel version on its CI machines past the point where they can no longer compile the 2.1 source tree, so this doesn't build anymore. We could probably fix it by installing our own Bazel, but at this point it's probably better to wait for #6761 first. |
garyverhaegen-da
force-pushed
the
patch-windows-bazel-ux
branch
2 times, most recently
from
9fb03f6 to
f665a11
Compare
This does not get used very often so it is likely nobody will remember how it works when we do use it. It's And due to the ordering Azure makes of jobs in its UI, it's very easy to miss that there is a final, Linux-based step and the values are actually printed there. So this adds a little note to remind us of that. Note that as this changes the `ci/patch_bazel_windows` folder, this will also generate a new Bazel, so this PR will also update the Scoop reference. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
patch-windows-bazel-ux
branch
from
f665a11 to
b61ffaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not get used very often so it is likely nobody will remember how it works when we do use it. It's And due to the ordering Azure makes of jobs in its UI, it's very easy to miss that there is a final, Linux-based step and the values are actually printed there.
So this adds a little note to remind us of that.
Note that as this changes the
ci/patch_bazel_windowsfolder, this will also generate a new Bazel, so this PR will also update the Scoop reference.CHANGELOG_BEGIN
CHANGELOG_END