sandbox-perf: Fix broken benchmarks and make sure they stay fixed. #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sandbox-perf` build has been failing for a while with the following errors: ``` INFO: From Generating benchmark code for //ledger/sandbox-perf:sandbox-perf_codegen: JMH benchmark generation: JMH Benchmark generator failed JMH benchmark generation: Benchmark classes should not be final. [com.digitalasset.platform.sandbox.perf.LargeTransactionBench] JMH benchmark generation: The instantiated @State class cannot be abstract. [com.digitalasset.platform.sandbox.perf.PerfBenchState] ``` However, these errors are ignored; running the benchmarks runs the `AcsBench` benchmark and ignores the fact `LargeTransactionBench` and `SimpleBench` failed to compile. I've fixed the errors by making sure that classes are not final, and that `SimpleBench` uses a concrete state class. This also introduces a cheap patch to the Scala JMH Bazel rules that makes sure they fail if there are any errors. I'm not really sure how to patch the Bazel rules properly, but someone else might have an idea. :-) CHANGELOG_BEGIN CHANGELOG_END
SamirTalwar
requested review from
gerolf-da,
rautenrieth-da and
stefanobaghino-da
as code owners
stefanobaghino-da
approved these changes
Jan 29, 2020
aherrmann-da
approved these changes
Jan 29, 2020
| @@ -0,0 +1,46 @@ | |||
| diff --git a/src/scala/io/bazel/rules_scala/jmh_support/BenchmarkGenerator.scala b/src/scala/io/bazel/rules_scala/jmh_support/BenchmarkGenerator.scala | |||
There was a problem hiding this comment.
That looks good to me, would be great to upstream to https://github.com/bazelbuild/rules_scala
There was a problem hiding this comment.
Opened: bazelbuild/rules_scala#977
|
FYI @aherrmann-da: this has now been patched upstream in bazelbuild/rules_scala#977, so when we upgrade Bazel to v2.0, we can potentially upgrade |
|
@SamirTalwar-DA Awesome, thanks for upstreaming this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sandbox-perfbuild has been failing for a while with the followingerrors:
However, these errors are ignored; running the benchmarks runs the
AcsBenchbenchmark and ignores the factLargeTransactionBenchandSimpleBenchfailed to compile.I've fixed the errors by making sure that classes are not final, and
that
SimpleBenchuses a concrete state class.This also introduces a cheap patch to the Scala JMH Bazel rules that
makes sure they fail if there are any errors.
I'm not really sure how to patch the Bazel rules properly, but someone
else might have an idea. :-)
Closes #4229.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.