Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WUC-14: Button #32

Closed
wants to merge 1 commit into from
Closed

WUC-14: Button #32

wants to merge 1 commit into from

Conversation

Uzhastin-Nikita
Copy link
Collaborator

@Uzhastin-Nikita Uzhastin-Nikita commented Mar 25, 2022

Task

Closes # 14

Description

Перенес компонент Button

@Uzhastin-Nikita Uzhastin-Nikita added the ready to review готово к просмотру label Mar 25, 2022
@Uzhastin-Nikita Uzhastin-Nikita self-assigned this Mar 25, 2022
@Uzhastin-Nikita Uzhastin-Nikita removed the ready to review готово к просмотру label Mar 25, 2022
@Uzhastin-Nikita Uzhastin-Nikita linked an issue Mar 28, 2022 that may be closed by this pull request
41 tasks
@Uzhastin-Nikita Uzhastin-Nikita added frontend ready to review готово к просмотру labels Apr 5, 2022
Copy link
Member

@4ingiZ88 4ingiZ88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

использовть миксин $color-...

border-radius: 6px;
padding: 18px 40px;
background: transparent;
color: #ffffff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

перенести в переменные color: $color...


import cx from 'classnames'

// eslint-disable-next-line css-modules/no-unused-class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

просмотреть неиспользуемые стили. и удалить эту строку

@import 'src/scss/mixins';

.primary {
border: 1px solid #fff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

использовть миксин $color-...

border-radius: 6px;
padding: 18px 40px;
background: transparent;
color: #fff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

использовть миксин $color-...

@Uzhastin-Nikita Uzhastin-Nikita deleted the feature/WUC-14__Button branch April 21, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready to review готово к просмотру
Projects
None yet
Development

Successfully merging this pull request may close these issues.

- Migration existing components
2 participants