BACKEND: Python Django, REST and DB #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-homeless-god
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Add pycache to gitignore
| # See https://docs.djangoproject.com/en/5.1/howto/deployment/checklist/ | ||
|
|
||
| # SECURITY WARNING: keep the secret key used in production secret! | ||
| SECRET_KEY = 'django-insecure-dtk7$@ho6ty&4g-fe!ig^c81z27nkd@#r#^^e5jd++868gf_jh' |
There was a problem hiding this comment.
put it to the .env and import here from os.getenv
Comment on lines
88
to
93
| # DATABASES = { | ||
| # "default": { | ||
| # "ENGINE": "django.db.backends.sqlite3", | ||
| # "NAME": "mydatabase", | ||
| # } | ||
| # } |
| admin.site.register(Report) | ||
|
|
||
| admin.site.register(Stages) | ||
| admin.site.register(Employee) |
There was a problem hiding this comment.
add an empty line at the end of the file
| admin.site.register(Project) | ||
| admin.site.register(Report) | ||
|
|
||
| admin.site.register(Stages) |
There was a problem hiding this comment.
It's better to name it Objective
| def __str__(self): | ||
| return self.project_name | ||
|
|
||
| class Stages(models.Model): |
TrafficLight_Python/projects/urls.py
Outdated
| urlpatterns = [ | ||
| path("", views.index, name="index"), | ||
| path("<int:project_id>", views.details, name="details") | ||
| ] |
There was a problem hiding this comment.
Add an empty line at the end of the file
Comment on lines
16
to
21
| def details(request, project_id): | ||
| try: | ||
| projects = Project.objects.get(pk=project_id) | ||
| except Project.DoesNotExist: | ||
| raise Http404("Project does not exist") | ||
| return render(request, "detail.html", {"projects": projects}) |
There was a problem hiding this comment.
we need no to have CRUD at views
return at the end just projects, need not to render
CRUD for a project in progress
… from migrations to .gitignore, removed garbage from admin.py, report_creator field in Report model
the-homeless-god
force-pushed
the
backend_python
branch
from
70c9adf
to
52e274b
Compare
the-homeless-god
changed the title
the-homeless-god
approved these changes
Aug 15, 2024
|
LGTM 🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
# 1.0.0 (2024-08-15) ### Features * **backend:** Python Django, REST and DB ([#4](#4)) ([66f57d0](66f57d0)) * **frontend, ci:** add configurations ([d78557d](d78557d)) * **frontend:** add an application ([38ce889](38ce889)) * **frontend:** create web folder with use react ts vite ([3dc5495](3dc5495))
|
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRUD for a project in progress