change python version in README.rst #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhua0320
changed the title
sbillinge
reviewed
Sep 4, 2024
README.rst
Outdated
| @@ -44,7 +44,7 @@ http://diffpy.github.io/diffpy.srmise. | |||
| Getting Started | |||
| ================= | |||
|
|
|||
| The diffpy.srmise package requires Python 2.6 or 2.7 and the following software: | |||
| The diffpy.srmise package requires Python 3.10, 3.11, or 3.12 and the following software: | |||
|
|
|||
| * ``setuptools`` - software distribution tools for Python | |||
There was a problem hiding this comment.
We can remove these too. Please double check that the we are using the installation instructions from the cookie cutter and only keep things from the old readme that are needed.
sbillinge
reviewed
Sep 4, 2024
sbillinge
reviewed
Sep 5, 2024
README.rst
Outdated
| When installing for MacPorts, make sure the MacPorts bin directory is the first | ||
| in the system PATH and that python27 is selected as the default Python version | ||
| in MacPorts:: | ||
| diffpy.srmise Package, https://github.com/diffpy/diffpy.srmise |
There was a problem hiding this comment.
This one has a published paper to cite, so please replace (here and in the docs) this line with:
L. Granlund, Billinge, S. J. L., and P. M. Duxbury. “Algorithm for systematic peak extraction from atomic
pair distribution functions”. In: Acta Crystallogr. A 71.4 (2015), pp. 392–409. DOI:
10.1107/S2053273315005276.
sbillinge
approved these changes
Sep 26, 2024
stevenhua0320
added a commit
to stevenhua0320/diffpy.srmise
that referenced
this pull request
Sep 27, 2024
This reverts commit c856057.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change Python requirment version in README.rst, please merge that before releasing. Thanks!