Issue 650 872 multi license headers #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
requested changes
Nov 9, 2021
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/FormatExtension.java
Outdated
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/FormatExtension.java
Outdated
Show resolved
Hide resolved
|
@nedtwigg Would it be fine if I just update this existing PR with commit with changes?? |
|
I prefer new commits to reduce review burden :) |
added 7 commits
November 9, 2021 22:52
…icense header variant inside one format, names should be unique, if content pattern is not set or there are multiple matches, last licenseHeader wins
…isLicenseHeaderStep method to subclasses to maintain check in one class
…ocs copy/paste typo
…anges text to follow style of previous entries
igorbeslic
force-pushed
the
ISSUE-650-872-multi-license-headers
branch
from
6dd24d6 to
8037240
Compare
|
You've got some spotbugs warnings. You can view locally with |
:) @nedtwigg thank you for patience - I superficially went through contributing and code_of_conduct - it is cause of glitches you see in my PR |
|
Very sorry for the long delay, this is an excellent PR that deserved to be merged and released quicker. |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #650
Fixes #872