Implement native cmd for gradle plugin #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carhartl
force-pushed
the
implement-nativecmd-gradle-plugin
branch
from
87721a1 to
b844080
Compare
|
Looks great! I'll give it ~24hrs then merge and release. |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evolution of #959.. now instead of adding an implementation for a single, particular binary, e.g. Terraform, this implements the native cmd step capability already existing in core and the Maven plugin for Gradle, allowing to run formatting tasks in Gradle with arbitrary binaries.
I felt this is adding more value while adding less code to maintain, even though we loose the ability to demand a particular version for the terraform binary.. :)
Updated https://github.com/carhartl/spotless-terraform-test accordingly..