Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply eclipse-jdt-4.8.1 #960

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Apply eclipse-jdt-4.8.1 #960

merged 1 commit into from
Oct 9, 2021

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Oct 9, 2021

The new version fixes module-info formatting.
See #958 for details.

@fvgh fvgh force-pushed the apply-eclipse-module-info-fix branch from 970a164 to 766713a Compare October 9, 2021 17:25
The new version fixes module-info formatting.
@fvgh fvgh force-pushed the apply-eclipse-module-info-fix branch from 766713a to b0b7c17 Compare October 9, 2021 18:17
@fvgh fvgh requested a review from nedtwigg October 9, 2021 18:32
if (1 == method.getParameterCount()) {
return input -> (String) method.invoke(formatter, input);
}
return (FormatterFunc.NeedsFile) (input, file) -> (String) method.invoke(formatter, input, file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat trick, LGTM.

@fvgh fvgh merged commit 59819eb into main Oct 9, 2021
@fvgh fvgh deleted the apply-eclipse-module-info-fix branch October 9, 2021 19:53
@fvgh fvgh restored the apply-eclipse-module-info-fix branch October 10, 2021 08:09
@nedtwigg
Copy link
Member

Published in plugin-gradle 5.17.0 and plugin-maven 2.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants