-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
com.diffplug.spotless 5.0 #640
Conversation
…t was set, now they throw errors.
…lder versions of Gradle.
…dern' flag anymore.
…entation details live in `SpotlessExtensionImpl`.
…details live in `SpotlessTaskImpl`.
…/" for speed gains.
Edit 7/7/20: added recommendation to the redirect message above about the bad performance of "target '**/" |
This is a big PR, and people are busy, no worries :). I plan to merge and release this tonight. If you would like me to delay, feel free to ask for more time. The code change is very simple, just deleting deprecated things. The main thing that would benefit from a second pair of eyes is the migration message above, but having sat on it for a week, I feel pretty good about it. |
Shouldn't the |
plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java
Outdated
Show resolved
Hide resolved
Yes, good catch! Thanks! |
Released, thanks @thc202! |
Great job on all of the Spotless improvements for Spotless 5.x. It's great that we can now leverage the newer features of Gradle. Thanks @nedtwigg !!! |
Oh, and thanks for taking on the work to make the task inputs relocatable. I've done some rudimentary testing and it looks good so far. I'll report back any issues that I see in the wild. |
Thanks for the help getting us here! The new task layout you implemented is much better. |
This PR closes out #600. It's much simpler than the long list of commits looks. All I did was:
SpotlessExtensionBase
->SpotlessExtension
, andSpotlessExtension(Modern -> Impl)
SpotlessTaskBase
->SpotlessTask
, andSpotlessTask(Modern -> Impl)
com.diffplug.spotless
(lets us set new tags)com.diffplug.gradle.spotless
now gives this error message:I'm open to feedback on anything, but I think the main decision points are:
SpotlessExtension
andSpotlessTask
in a separate API vs impl piece.We could smush them back together, but I thought that the "spotlessModern" refactor where we had both implementations side-by-side was useful. Since we did the work to split them up, we might as well keep them that way, but I'm open to other thoughts.