Modify FileSignature so that it can be relocated based on content
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f desired, or rely on local timestamps if you don't care about relocating.
|
This idea didn't work, and #571 is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve #566 by using
ThreadLocalto serializeFileSignaturedifferently when it is being used by Gradle than by other consumers. This allowsSpotlessCacheto use the fastpath, and only Gradle up-to-date checking uses the slow path.Ideally, we could use the fast path for Gradle up-to-date checking too, and we'd somehow have a way to alter/canonicalize the cache key only for the remote buildcache. @bigdaz am I correct that no such API exists?