Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis to CircleCI #570

Merged
merged 29 commits into from
May 5, 2020
Merged

Switch from Travis to CircleCI #570

merged 29 commits into from
May 5, 2020

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented May 5, 2020

No description provided.

@nedtwigg nedtwigg changed the title First experiment enabling CircleCI. Switch from Travis to CircleCI May 5, 2020
@nedtwigg
Copy link
Member Author

nedtwigg commented May 5, 2020

On Travis, we were seeing build times of ~10-20 mins for each commit. On CircleCI, running the same tests, we're seeing ~3 mins. The real advantage, though, is that now any committer can ship a new version from the CI dashboard.

@nedtwigg nedtwigg merged commit a129960 into master May 5, 2020
@nedtwigg nedtwigg deleted the feat/circleci branch May 5, 2020 09:48
@jbduncan
Copy link
Member

jbduncan commented May 5, 2020

Fantastic work! 👏

Did you ever consider GitHub Actions at some point? I suppose I'm curious to know if Actions is slower than CircleCI or something. :)

@jbduncan
Copy link
Member

jbduncan commented May 5, 2020

I'm also curious to know more about this CircleCI dashboard. Is it open to external contributors, by any chance?

@nedtwigg
Copy link
Member Author

nedtwigg commented May 5, 2020

Did you ever consider GitHub Actions at some point?

I have only glanced at Actions. I use CircleCI on other projects and I've been very happy with it, so it's been on my todo list to transfer this off of Travis for a while.

If Actions is way better than Circle I'm still open to adopting it, but in general I try to buy/advertise services from more independent vendors rather than platform-monopolists when I can (even if the platform-monopolist is behaving admirably today, which they are).

Is it open to external contributors, by any chance?

I hope so - that is my intent. If you click the commit status for any commit on master (the only branch where the deploy pipeline runs), then hopefully you should see screens like this:

Screen Shot 2020-05-05 at 2 49 31 AM

The "on hold" jobs allow a committer to approve them, which will then ship lib, plugin-gradle, and plugin-maven, or just one of the plugins.

Screen Shot 2020-05-05 at 2 50 13 AM

When you approve a hold, the job that runs publishes to jcenter, mavenCentral, plugin portal, updates changelog, and tags.

@jbduncan
Copy link
Member

Hi @nedtwigg, sorry for the delay in responding, busy week!

I have only glanced at Actions. I use CircleCI on other projects and I've been very happy with it, so it's been on my todo list to transfer this off of Travis for a while.

If Actions is way better than Circle I'm still open to adopting it, but in general I try to buy/advertise services from more independent vendors rather than platform-monopolists when I can (even if the platform-monopolist is behaving admirably today, which they are).

Sounds very reasonable to me! Speed and relative independence sound like great pluses to have. 👍

If you click the commit status for any commit on master (the only branch where the deploy pipeline runs), then hopefully you should see screens like this...

Awesome, I can confirm that I have access! (I wasn't able to see the commit statuses before because I was viewing GitHub on my phone.)

@JLLeitschuh
Copy link
Member

is that now any committer can ship a new version from the CI dashboard.

Isn't that a security risk?

@nedtwigg
Copy link
Member Author

Some projects automatically cut a release for every commit to master. This is just that, except the release only happens if a committer tells CI “release this one” from the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants