Try fixing #427 #434
Merged
Try fixing #427 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also - is there a recommended pattern for installing to mavenLocal to test in other projects? |
|
I just cleared the travis cache and restarted the build. If it works now, then the problem was #429 all along. It seems that the newer gradle versions are less friendly to our |
ZacSweers
force-pushed
the
z/fixGradleWarning
branch
from
a7b9b13
to
10a908d
Compare
|
Verified locally that no more warnings are produced when I try in my side project - https://github.com/zacsweers/catchup, and also still works if I change some formatting in files |
|
Great! Thanks for the broad modernization push Zac! |
|
Happy to help! |
|
Released in 3.24.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #427 with its suggested solution. Kicking this to CI as I'm not able to get tests to pass locally for this project right now for some reason (I suspect it's due to my local jdk version)