-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScalaFmt takes filepath into consideration. #1854
Conversation
162a94d
to
72fe5de
Compare
Looks like this breaks the integration tests, not sure why. |
30924e4
to
47c06a8
Compare
fix formatting.
47c06a8
to
1fff681
Compare
@nedtwigg took me almost a year to come back to it finally. I figured it out. ScalaFmt treats certain files specially, i.e. Once I've started feeding real file path into scalafmt, this difference become apparent. In maven test suite there's a test that checks whether |
@@ -1,4 +1,4 @@ | |||
@ foobar("annot", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change here is to eliminate the difference in formatting between .sc and .scala files so that test harness would still work the same.
Thanks for coming back! |
fix formatting.
Head branch was pushed to by a user without write access
lol after all that I delete the actual fix, lol. Thanks for checking and fixing! |
ScalaFmt extension takes the file path into account to get the fileOverride scalafmt.conf section to work correctly.