Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependecy groovy-xml to 4.0.6 #1405

Closed
wants to merge 2 commits into from
Closed

chore(deps): update dependecy groovy-xml to 4.0.6 #1405

wants to merge 2 commits into from

Conversation

TomBursch
Copy link

@TomBursch TomBursch commented Nov 23, 2022

Closes #1399

upgrades org.codehaus.groovy:groovy-xml:3.0.10 to org.apache.groovy:groovy-xml:4.0.6

@nedtwigg
Copy link
Member

All of the Gradle tests fail, I think because the Groovy version needs to match Gradle's version. Do you have a specific need to update the Groovy? I'm happy to merge this if you figure out a way for it to not break Gradle.

@TomBursch
Copy link
Author

TomBursch commented Nov 24, 2022

Hi, thanks for the fast response! Do you have a clue what the problem could be here? I'm already running the latest gradle version (build fails for me too) and I couldn't find anything where you manually set a different gradle version.

One of our plugin dependencies also uses a later version of groovy and due to the name change some dependency conflicts arise. Mainly that two different transitive dependencies have the same capabilities.

@nedtwigg
Copy link
Member

We test on different Gradle versions for different tests

.withGradleVersion(GradleVersionSupport.MINIMUM.version)

public enum GradleVersionSupport {
JRE_11("5.0"), MINIMUM(SpotlessPlugin.MINIMUM_GRADLE),
// technically, this API exists in 6.5, but the flags for it change in 6.6, so we build to that
CONFIGURATION_CACHE("6.6"),
// https://docs.gradle.org/7.5/userguide/configuration_cache.html#config_cache:stable
STABLE_CONFIGURATION_CACHE("7.5");

I'm probably okay with bumping our minimum required Gradle to support this change because other people will have this problem eventually too.

@ben-snaize
Copy link

Been watching this fix, as it breaks parents like react-native-reanimated. Any ideas when it will go into production? We're currently have to patch it away.

@nedtwigg
Copy link
Member

nedtwigg commented Jan 2, 2023

Well this is a bit embarassing, but it turns out we don't even need this dep at all anymore.

What happened is that we did use groovy-xnl inside of the JDT step in the past, and at some point it was refactored out but the dep wasn't removed.

@nedtwigg nedtwigg closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade org.codehaus.groovy to org.apache.groovy
3 participants