Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven plugin - override ratchetFrom from parent pom to disable ratchet #1132

Closed
jandhollander opened this issue Feb 16, 2022 · 3 comments
Closed
Labels

Comments

@jandhollander
Copy link

I have a parent pom that defines
<ratchetFrom>origin/main</ratchetFrom>

However, I would like to override this in the child pom to not use the ratchet feature.
The way Maven allows overriding of parameters is that you need to specify the tag to override in your child pom configuration, but doing so never results in disabling of the ratchet feature, but shows a "apply failed: Invalid ref name: xxxx" error. Even if an empty ratchetFrom tag is defined.

I looked around in the code and found that if ratchetFrom is defined, no matter the value, the ratchet feature is enabled.

Is there a way around this?

@nedtwigg nedtwigg added the bug label Feb 16, 2022
@nedtwigg
Copy link
Member

Is there a way around this?

Sounds like a PR could fix it ;-)

@jandhollander
Copy link
Author

I'll see what I can do...

jandhollander pushed a commit to jandhollander/spotless that referenced this issue Feb 17, 2022
jandhollander added a commit to jandhollander/spotless that referenced this issue Feb 17, 2022
@nedtwigg
Copy link
Member

Fixed in plugin-maven 2.21.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants