Skip to content

Conversation

@tautschnig
Copy link
Collaborator

Implement null checking for monitorenter/monitorexit bytecode instructions to throw NullPointerException when the monitor object is null, as per Java bytecode specification.

Fixes: #1236

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (1505c36) to head (f5f00d1).

Files with missing lines Patch % Lines
...src/java_bytecode/java_bytecode_convert_method.cpp 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8757   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files         1700     1700           
  Lines       188254   188272   +18     
  Branches        73       73           
========================================
+ Hits        150615   150631   +16     
- Misses       37639    37641    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Implement null checking for `monitorenter`/`monitorexit` bytecode
instructions to throw `NullPointerException` when the monitor object is
null, as per Java bytecode specification.

Fixes: diffblue#1236
@tautschnig tautschnig force-pushed the fix-1236-synchronized-null branch from 060ff98 to f5f00d1 Compare December 2, 2025 11:31
@tautschnig tautschnig marked this pull request as ready for review December 2, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java synchronized blocks don't throw NullPointerException

2 participants