Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include of <ctime> #7871

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

thomasspriggs
Copy link
Collaborator

The type std::time_t is used in src/goto-checker/symex_coverage.cpp. std::time_t is defined in <ctime>, but was not previously included. This caused build failures locally, when building with Visual Studio Community 2019 Version 16.7.4.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The type `std::time_t` is used in this file. `std::time_t` is defined in
`<ctime>`, but was not previously included. This caused build failures
locally, when building with Visual Studio Community 2019 Version 16.7.4.
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.95% 🎉

Comparison is base (3e3ba26) 77.89% compared to head (dcc5934) 78.84%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7871      +/-   ##
===========================================
+ Coverage    77.89%   78.84%   +0.95%     
===========================================
  Files         1699     1699              
  Lines       195294   195294              
===========================================
+ Hits        152128   153987    +1859     
+ Misses       43166    41307    -1859     
Files Changed Coverage Δ
src/goto-checker/symex_coverage.cpp 97.87% <ø> (ø)

... and 64 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 228b9dd into diffblue:develop Aug 31, 2023
35 checks passed
@thomasspriggs thomasspriggs deleted the tas/ctime_fix branch August 31, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants