Skip to content

Conversation

@martin-cs
Copy link
Collaborator

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #5871 (a56d059) into develop (e969911) will decrease coverage by 0.00%.
The diff coverage is 89.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5871      +/-   ##
===========================================
- Coverage    72.90%   72.90%   -0.01%     
===========================================
  Files         1423     1423              
  Lines       154216   154196      -20     
===========================================
- Hits        112428   112412      -16     
+ Misses       41788    41784       -4     
Impacted Files Coverage Δ
src/analyses/global_may_alias.cpp 0.00% <0.00%> (ø)
src/analyses/uninitialized_domain.cpp 0.00% <0.00%> (ø)
src/goto-diff/change_impact.cpp 0.00% <ø> (ø)
src/goto-diff/goto_diff_parse_options.cpp 58.67% <ø> (ø)
src/goto-instrument/uninitialized.cpp 0.00% <0.00%> (ø)
src/goto-programs/remove_const_function_pointers.h 100.00% <ø> (ø)
src/goto-programs/restrict_function_pointers.h 100.00% <ø> (ø)
src/goto-symex/auto_objects.cpp 21.95% <0.00%> (+0.52%) ⬆️
src/goto-symex/goto_symex.h 92.30% <ø> (ø)
src/goto-symex/symex_function_call.cpp 92.89% <50.00%> (+0.50%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818fdf2...a56d059. Read the comment docs.

@martin-cs
Copy link
Collaborator Author

The code coverage results say that there has been a decrease in coverage. Given I have only changed string formats, I'm going to ignore that and merge it anyway.

@martin-cs martin-cs merged commit d8b71f5 into diffblue:develop Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants