Skip to content

Conversation

@tautschnig
Copy link
Collaborator

We had almost-the-same code in two places. Use the method introduced in
cfd387d as the single implementation.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We had almost-the-same code in two places. Use the method introduced in
cfd387d as the single implementation.
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #5852 (50f775e) into develop (4d7158f) will increase coverage by 0.00%.
The diff coverage is 93.47%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5852   +/-   ##
========================================
  Coverage    72.87%   72.88%           
========================================
  Files         1421     1421           
  Lines       154208   154256   +48     
========================================
+ Hits        112386   112428   +42     
- Misses       41822    41828    +6     
Impacted Files Coverage Δ
src/util/format_expr.cpp 85.77% <92.40%> (+0.77%) ⬆️
src/analyses/goto_check.cpp 88.21% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743c2d1...50f775e. Read the comment docs.

Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍🏻

@tautschnig tautschnig merged commit d49f68f into diffblue:develop Feb 24, 2021
@tautschnig tautschnig deleted the cleanup-allocs branch February 24, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants