Skip to content

cpplint sed format improvements #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2017
Merged

cpplint sed format improvements #558

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a43b862
Explore matching nested bracketed stuff
rjmunro Feb 16, 2017
4e6c7b2
Fix ; after } errors
rjmunro Feb 20, 2017
89d259e
Fix missing space after , errors
rjmunro Feb 20, 2017
ce6b2b4
Replace tabs globally within the line
rjmunro Feb 20, 2017
0b11c43
Add space after comma globally within the line
rjmunro Mar 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,9 +550,13 @@
"Remove space before ( in switch (": "s/switch (/switch(/",
"Should have a space between // and comment": 's/\/\//\/\/ /',
"Missing space before {": r's/\([^ ]\){/\1 {/',
"Tab found, replace by spaces": r's/\t/ /',
"Tab found, replace by spaces": r's/\t/ /g',
"Line ends in whitespace. Consider deleting these extra spaces.": r's/\s*$//',
#"Redundant blank line at the end of a code block should be deleted.": "d", # messes up line numbers for other errors.
"You don't need a ; after a }": r's/};/}/',
"Missing space after ,": r's/,\([^ ]\)/, \1/g',
# "Statement after an if should be on a new line": r's/^\(\s*\)if *\(([^()]*)\) *\(.*\)$/\1if\2\n\1 \3/', # Single layer of nested bracets
# "Statement after an if should be on a new line": r's/^\(\s*\)if *\((\([^()]\|([^()]*)\)*)\) *\(.*\)$/\1if\2\n\1 \4/', # Max 2 layers of nested bracets; messes up line numbers for other errors.
# "Redundant blank line at the end of a code block should be deleted.": "d", # messes up line numbers for other errors.
}

_regexp_compile_cache = {}
Expand Down