Skip to content

Clean out various bits of legacy code #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2018
Merged

Clean out various bits of legacy code #1823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bac484
cleanout decision_proceduret::in_core
kroening Feb 11, 2018
77c8b9c
remove translation for certain boolean program constructs
kroening Feb 11, 2018
63f09ac
remove unused function make_next_state
kroening Feb 11, 2018
733f3b8
remove old-style constructor for member_exprt
kroening Feb 11, 2018
11714b2
use constant_exprt version of to_integer
kroening Feb 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/util/decision_procedure.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,4 @@ Author: Daniel Kroening, [email protected]

#include "decision_procedure.h"

#include <cassert>

bool decision_proceduret::in_core(const exprt &expr)
{
UNREACHABLE;
return true;
}
Copy link
Collaborator

@tautschnig tautschnig Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only half-related to the change: I believe it would be good to explicitly define the destructor in this .cpp file so that the compiler has an idea where to place the virtual table.

3 changes: 0 additions & 3 deletions src/util/decision_procedure.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ class decision_proceduret:public messaget
return dec_solve();
}

// old-style, will go away
virtual bool in_core(const exprt &expr);

// return a textual description of the decision procedure
virtual std::string decision_procedure_text() const=0;

Expand Down