Remove default arguments from abstract_environmentt::abstract_object_factory

Default arguments on a virtual function aren't safe. Even through this
function isn't overriden anywhere now, it's a latent bug waiting for the
future.

Author: jezhiggins

src/analyses/variable-sensitivity/abstract_environment.cpp

@@ -74,7 +74,7 @@ abstract_environmentt::eval(const exprt &expr, const namespacet &ns) const
   {
     // It is important that this is top as the abstract object may not know
     // how to handle the expression
-    return abstract_object_factory(simplified_expr.type(), ns, true);
+    return abstract_object_factory(simplified_expr.type(), ns, true, false);
   }
 }
 
@@ -389,7 +389,7 @@ abstract_object_pointert abstract_environmentt::eval_expression(
   // The value of the temporary abstract object is ignored, its
   // purpose is just to dispatch the expression transform call to
   // a concrete subtype of abstract_objectt.
-  auto eval_obj = abstract_object_factory(e.type(), ns, true);
+  auto eval_obj = abstract_object_factory(e.type(), ns, true, false);
   auto operands = eval_operands(e, *this, ns);
 
   return eval_obj->expression_transform(e, operands, *this, ns);

src/analyses/variable-sensitivity/abstract_environment.h

@@ -150,8 +150,8 @@ class abstract_environmentt
   virtual abstract_object_pointert abstract_object_factory(
     const typet &type,
     const namespacet &ns,
-    bool top = true,
-    bool bottom = false) const;
+    bool top,
+    bool bottom) const;
 
   /// For converting constants in the program
   ///

src/analyses/variable-sensitivity/abstract_object.cpp

@@ -129,7 +129,7 @@ abstract_object_pointert abstract_objectt::expression_transform(
 
     if(const_op.is_nil())
     {
-      return environment.abstract_object_factory(copy.type(), ns, true);
+      return environment.abstract_object_factory(copy.type(), ns, true, false);
     }
   }
 
@@ -144,7 +144,7 @@ abstract_object_pointert abstract_objectt::write(
   const abstract_object_pointert &value,
   bool merging_write) const
 {
-  return environment.abstract_object_factory(type(), ns, true);
+  return environment.abstract_object_factory(type(), ns, true, false);
 }
 
 bool abstract_objectt::is_top() const

src/analyses/variable-sensitivity/constant_abstract_value.cpp

@@ -159,7 +159,7 @@ constant_abstract_valuet::try_transform_expr_with_all_rounding_modes(
     auto current = possible_result->to_constant();
     if(current.is_nil() || current != first)
     {
-      return environment.abstract_object_factory(expr.type(), ns);
+      return environment.abstract_object_factory(expr.type(), ns, true, false);
     }
   }
   return possible_results.front();

src/analyses/variable-sensitivity/full_array_abstract_object.cpp

@@ -168,7 +168,7 @@ abstract_object_pointert full_array_abstract_objectt::read_component(
   const namespacet &ns) const
 {
   if(is_top())
-    return environment.abstract_object_factory(expr.type(), ns, true);
+    return environment.abstract_object_factory(expr.type(), ns, true, false);
 
   auto read_element_fn =
     [this, &environment, &ns](const index_exprt &index_expr) {

src/analyses/variable-sensitivity/full_struct_abstract_object.cpp

@@ -83,7 +83,7 @@ abstract_object_pointert full_struct_abstract_objectt::read_component(
 
   if(is_top())
   {
-    return environment.abstract_object_factory(expr.type(), ns, true);
+    return environment.abstract_object_factory(expr.type(), ns, true, false);
   }
   else
   {
@@ -100,7 +100,7 @@ abstract_object_pointert full_struct_abstract_objectt::read_component(
     }
     else
     {
-      return environment.abstract_object_factory(member_expr.type(), ns, true);
+      return environment.abstract_object_factory(member_expr.type(), ns, true, false);
     }
   }
 }

src/analyses/variable-sensitivity/interval_abstract_value.cpp

@@ -304,7 +304,7 @@ abstract_object_pointert interval_abstract_valuet::expression_transform(
         if(op_as_constant.is_nil())
         {
           auto top_object =
-            environment.abstract_object_factory(expr.type(), ns, true);
+            environment.abstract_object_factory(expr.type(), ns, true, false);
           auto top_context_object =
             std::dynamic_pointer_cast<const context_abstract_objectt>(
               top_object);
@@ -340,7 +340,7 @@ abstract_object_pointert interval_abstract_valuet::expression_transform(
   }
 
   if(num_operands == 0)
-    return environment.abstract_object_factory(expr.type(), ns, true);
+    return environment.abstract_object_factory(expr.type(), ns, true, false);
 
   if(expr.id() == ID_if)
     return evaluate_conditional(expr, interval_operands, environment, ns);

src/analyses/variable-sensitivity/variable_sensitivity_domain.cpp

@@ -46,7 +46,7 @@ void variable_sensitivity_domaint::transform(
     abstract_object_pointert top_object =
       abstract_state
         .abstract_object_factory(
-          to_code_decl(instruction.code).symbol().type(), ns, true)
+          to_code_decl(instruction.code).symbol().type(), ns, true, false)
         ->update_location_context(write_location, true);
     abstract_state.assign(
       to_code_decl(instruction.code).symbol(), top_object, ns);
@@ -318,7 +318,7 @@ void variable_sensitivity_domaint::transform_function_call(
               std::stack<exprt>(),
               nil_exprt(),
               abstract_state.abstract_object_factory(
-                called_arg.type().subtype(), ns, true),
+                called_arg.type().subtype(), ns, true, false),
               false);
           }
         }
@@ -331,7 +331,7 @@ void variable_sensitivity_domaint::transform_function_call(
             abstract_state.assign(
               symbol_exprt(symbol.first, symbol.second.type),
               abstract_state.abstract_object_factory(
-                symbol.second.type, ns, true),
+                symbol.second.type, ns, true, false),
               ns);
           }
         }