Clean up warnings in constant_abstract_valuet

Author: jezhiggins

src/analyses/variable-sensitivity/constant_abstract_value.cpp

@@ -33,18 +33,18 @@ index_range_ptrt make_constant_index_range(const exprt &val)
   return std::make_shared<constant_index_ranget>(val);
 }
 
-constant_abstract_valuet::constant_abstract_valuet(typet t)
+constant_abstract_valuet::constant_abstract_valuet(const typet &t)
   : abstract_value_objectt(t), value()
 {
 }
 
-constant_abstract_valuet::constant_abstract_valuet(typet t, bool tp, bool bttm)
+constant_abstract_valuet::constant_abstract_valuet(const typet &t, bool tp, bool bttm)
   : abstract_value_objectt(t, tp, bttm), value()
 {
 }
 
 constant_abstract_valuet::constant_abstract_valuet(
-  const exprt e,
+  const exprt &e,
   const abstract_environmentt &environment,
   const namespacet &ns)
   : abstract_value_objectt(e.type(), false, false), value(e)
@@ -209,7 +209,7 @@ constant_abstract_valuet::merge(abstract_object_pointert other) const
 }
 
 abstract_object_pointert constant_abstract_valuet::merge_constant_constant(
-  constant_abstract_value_pointert other) const
+  const constant_abstract_value_pointert &other) const
 {
   if(is_bottom())
   {

src/analyses/variable-sensitivity/constant_abstract_value.h

@@ -24,16 +24,14 @@ class constant_abstract_valuet : public abstract_value_objectt
     constant_abstract_value_pointert;
 
 public:
-  explicit constant_abstract_valuet(typet t);
-  constant_abstract_valuet(typet t, bool tp, bool bttm);
+  explicit constant_abstract_valuet(const typet &t);
+  constant_abstract_valuet(const typet &t, bool tp, bool bttm);
   constant_abstract_valuet(
-    const exprt e,
+    const exprt &e,
     const abstract_environmentt &environment,
     const namespacet &ns);
 
-  virtual ~constant_abstract_valuet()
-  {
-  }
+  ~constant_abstract_valuet() override = default;
 
   index_range_ptrt index_range(const namespacet &ns) const override;
 
@@ -107,7 +105,7 @@ class constant_abstract_valuet : public abstract_value_objectt
   ///         unless the merge is the same as this abstract object, in which
   ///         case it returns this.
   abstract_object_pointert
-  merge_constant_constant(constant_abstract_value_pointert other) const;
+  merge_constant_constant(const constant_abstract_value_pointert &other) const;
 
   exprt value;
 };