Refactor duplicated transaction management code #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for transactions is duplicated between SQLite and PostgreSQL. MySQL would have also used identical code. However, the SQL being executed is not universal across all backends. Oracle appears to use the same SQL, but SQL Server has its own special syntax for this. As such, I'm not comfortable promoting this to a default impl on the trait. Instead I've moved the code out into a shared trait/struct, and operate on that instead. I had wanted to make `TransactionManager` be generic over the backend, not the connection itself, since constraints for it will always be about the backend, but I ran into rust-lang/rust#39532 when attempting to do so.
killercup
approved these changes
Feb 4, 2017
| /// interface with this trait unless you are implementing a new connection | ||
| /// adapter. You should use [`Connection::transaction`][transaction], | ||
| /// [`Connection::test_transaction`][test_transaction], or | ||
| /// [`Connection::begin_test_transaction`][begin_test_transaction] instead. |
There was a problem hiding this comment.
You know I link links. Can you add some? Let's say, three?
There was a problem hiding this comment.
But you just said that you would link links. ;)
There was a problem hiding this comment.
Sorry, what I meant to say was that I link likes! :D
There was a problem hiding this comment.
I'm going to do it as a separate commit. I need to rebase something off this branch to open a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for transactions is duplicated between SQLite and PostgreSQL.
MySQL would have also used identical code. However, the SQL being
executed is not universal across all backends. Oracle appears to use the
same SQL, but SQL Server has its own special syntax for this. As such,
I'm not comfortable promoting this to a default impl on the trait.
Instead I've moved the code out into a shared trait/struct, and operate
on that instead.
I had wanted to make
TransactionManagerbe generic over the backend,not the connection itself, since constraints for it will always be about
the backend, but I ran into
rust-lang/rust#39532 when attempting to do so.