Change the order of generic arguments for InsertValues #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes to order of generic arguments for the `InsertValues` trait. This allows us to generate a sound impl of that trait via `#[derive(MultiConnection)]` that will be accepted by future rust compiler versions as well. This works as the backend type is this case local, while the table type is generic. By having first the backend type and then the table type we first have the local type, which is allowed according to the rust coherence rules. This is no breaking change as `InsertValues` is not part of the public API: https://docs.diesel.rs/2.1.x/diesel/index.html?search=insertvalues This fixes diesel-rs#4035
fmease
approved these changes
May 31, 2024
DavisRayM
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes to order of generic arguments for the
InsertValuestrait. This allows us to generate a sound impl of that trait via#[derive(MultiConnection)]that will be accepted by future rust compiler versions as well. This works as the backend type is this case local, while the table type is generic. By having first the backend type and then the table type we first have the local type, which is allowed according to the rust coherence rules.This is no breaking change as
InsertValuesis not part of the public API: https://docs.diesel.rs/2.1.x/diesel/index.html?search=insertvaluesThis fixes #4035