Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many Nightly Fixes #2376

Merged
merged 4 commits into from
May 2, 2020
Merged

Many Nightly Fixes #2376

merged 4 commits into from
May 2, 2020

Conversation

martell
Copy link
Contributor

@martell martell commented Apr 24, 2020 •
edited
Loading

Update to nightly that has clippy and rustfmt
Fix nightly builds rust-lang/rust#70814
Fix an intra doc link for diesel as a dev-dependency

@martell martell changed the title Update nightly in travis to match rust-toolchain Update nightly to address regression and match travis nightly to rust-toolchain Apr 24, 2020
@martell martell force-pushed the chore/missing-nightly-update branch from 2c1bd2d to 1c36df1 Compare April 24, 2020 08:37
@martell martell changed the title Update nightly to address regression and match travis nightly to rust-toolchain Change nightly to address regression and match travis nightly to rust-toolchain Apr 24, 2020
@weiznich weiznich requested a review from a team April 24, 2020 08:39
@martell martell force-pushed the chore/missing-nightly-update branch 10 times, most recently from 03a1ace to 4299754 Compare April 25, 2020 08:51
@martell martell changed the title Change nightly to address regression and match travis nightly to rust-toolchain Update nightly to match travis nightly to rust-toolchain and address regression Apr 25, 2020
@martell
Copy link
Contributor Author

martell commented Apr 25, 2020

@weiznich I think this should be good now, and ready for review :)

@martell martell changed the title Update nightly to match travis nightly to rust-toolchain and address regression Many Nightly Fixes Apr 25, 2020
@martell martell mentioned this pull request Apr 25, 2020
Closed
weiznich
weiznich requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo that new feature flag for diesel_migrations. If we really need to do something like that we should go with a raw --cfg "fix_for_whatever" flag, so that we do not introduce a new feature flag in our public API.

diesel_migrations/migrations_macros/Cargo.toml Outdated Show resolved Hide resolved
@martell martell force-pushed the chore/missing-nightly-update branch from 4299754 to c3ef454 Compare May 2, 2020 01:50
@martell martell force-pushed the chore/missing-nightly-update branch from c3ef454 to a19c6e3 Compare May 2, 2020 03:02
@martell
Copy link
Contributor Author

martell commented May 2, 2020

@weiznich I think I addressed all the concerns by updating :)

@weiznich weiznich merged commit 968e7f7 into diesel-rs:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor left review comments

@weiznich weiznich weiznich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martell @weiznich @JohnTitor