Properly encode BigDecimal values whose first digit is 10k
#1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @rubdos |
When serializing a numeric column, we need to take a decimal value and convert it to a list of its digits in base 10k. The serialization code had a bug when the first digit was exactly `10000`, resulting in the digits being `[10000, ...]` instead of `[1, 0, ...]`. This bug only affected the integral part, as the decimal portion uses different logic in order ot strip trailing zeroes. Fixes #1044.
sgrif
force-pushed
the
sg-fix-decimal-encoding
branch
from
fb1ca8d
to
e1bbdf7
Compare
Eijebong
approved these changes
Jul 27, 2017
sgrif
added a commit
that referenced
this pull request
Jul 28, 2017
Properly encode `BigDecimal` values whose first digit is 10k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing a numeric column, we need to take a decimal value and
convert it to a list of its digits in base 10k. The serialization code
had a bug when the first digit was exactly
10000, resulting in thedigits being
[10000, ...]instead of[1, 0, ...]. This bug onlyaffected the integral part, as the decimal portion uses different logic
in order ot strip trailing zeroes.
Fixes #1044.