i18n(vi): translate combos page explanation + Round Robin label to Vietnamese - #51
Merged
Merged
Conversation
Add 5 keys to public/i18n/literals/vi.json: - Group models under one name... - Fallback, Round Robin, Fusion, Capacity auto-switch descriptions Mechanism: runtime i18n (src/i18n/runtime.js) reads vi.json as exact-match translation map; locale=vi users see translated text, locale=en falls back to upstream English. No base file touched (combos/page.js stays untouched); zero merge conflict risk on upstream rebase. Verify: - python3 -m json.tool vi.json: valid JSON - node scripts/diepxuan/check-custom-features.mjs: 360 PASS / 0 WARN / 0 FAIL - 5/5 keys match base file text exactly (incl. em-dash) Docs: docs/CUSTOM-FEATURES-MERGE-CHECKLIST.md §20.
Sếp yêu cầu trực tiếp: 'Round Robin' không dịch thành 'Vòng tròn'
(nghĩa đen, không đúng kỹ thuật). Bản dịch đúng trong ngữ cảnh
load balancing / scheduling là 'Luân phiên' (round-robin scheduling).
Changes:
- public/i18n/literals/vi.json:
* key 'Round Robin': 'Vòng tròn' -> 'Luân phiên' (fix chuẩn kỹ thuật)
* long-form key value: dùng 'Luân phiên — xoay vòng model...' thay vì lặp
'Round Robin — luân phiên model...'
* +3 keys mới cho STRATEGY_OPTIONS modal:
- 'Round Robin — rotate' -> 'Luân phiên — xoay vòng'
- 'Fallback — try in order' -> 'Fallback — thử theo thứ tự'
- 'Fusion — panel + judge' -> 'Fusion — panel + judge'
- docs/CUSTOM-FEATURES-MERGE-CHECKLIST.md §20: rev 2, bảng quyết định dịch,
smoke test mở rộng (modal strategy dropdown + ConnectionsCard).
Verify:
- python3 -m json.tool: JSON hợp lệ
- 201 keys, không trùng lặp
- node scripts/diepxuan/check-custom-features.mjs: 360 PASS / 0 WARN / 0 FAIL
- 'Round Robin' key giờ áp dụng cho 2 chỗ (combos bullet + ConnectionsCard)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mục đích
Bổ sung bản dịch tiếng Việt cho phần giải thích trong page Combos + label "Round Robin" trong ConnectionsCard + STRATEGY_OPTIONS modal. Khi user chọn locale
vi, runtime i18n tự thay thế qua JSON literal map.Thay đổi (2 commits, 2 files)
public/i18n/literals/vi.jsondocs/CUSTOM-FEATURES-MERGE-CHECKLIST.mdCơ chế
src/i18n/runtime.js) đọc exact-match key từpublic/i18n/literals/{locale}.json.Keys thêm/sửa (rev 2)
Round RobinLuân phiên(sửa từ "Vòng tròn" sai nghĩa đen)Round Robin — rotates models across requests to spread loadLuân phiên — xoay vòng model giữa các request để phân tảiRound Robin — rotateLuân phiên — xoay vòngFallback — try in orderFallback — thử theo thứ tựFusion — panel + judgeFusion — panel + judgeGroup models under one name, then pick a strategy per combo:Gom các model dưới một tên, rồi chọn chiến lược cho mỗi combo:Fallback — tries models in order (next on failure)Fallback — thử các model theo thứ tự (model tiếp theo khi lỗi)Fusion — queries all models in parallel...Fusion — truy vấn tất cả model song song...Capacity auto-switch — sends image/PDF/audio requests to a model that supports them firstCapacity auto-switch — gửi request hình ảnh/PDF/audio đến model hỗ trợ trướcKhông ảnh hưởng
Verify
python3 -m json.tool public/i18n/literals/vi.json: JSON hợp lệ, 201 keys, không trùng.node scripts/diepxuan/check-custom-features.mjs: 360 PASS / 0 WARN / 0 FAIL.—).src/app/(dashboard)/dashboard/combos/page.js+providers/components/ConnectionsCard.js.Smoke test
Fallback — thử theo thứ tự,Luân phiên — xoay vòng,Fusion — panel + judge.Liên quan