[easy] Trim the regex dependency #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-libra r+ |
|
📌 Commit 99564ba has been approved by |
|
☔ The latest upstream changes (presumably 7bb5e10) made this pull request unmergeable. Please resolve the merge conflicts. |
See rust-lang/regex#613 as it turns out we never use regex in a Unicode context, trim its transitive dependencies
|
🔒 Merge conflict |
huitseeker
force-pushed
the
trim-regex
branch
from
99564ba to
a79f67e
Compare
|
@bors-libra r=mimoo |
|
📌 Commit a79f67e has been approved by |
|
💡 This pull request was already approved, no need to approve it again. |
|
📌 Commit a79f67e has been approved by |
|
⌛ Testing commit a79f67e with merge a0696bab3d3b1fb7354bab4ed7bf28bf82032ba5... |
|
☀️ Test successful - checks-circle_commit_workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/regex#613
as it turns out we never use regex in a Unicode context, trim it.