Repository navigation
fix(base-red): prune stale ESLint suppression + align combo tests with #9630 - #9774
Merged
Merged
Conversation
The no-explicit-any count for open-sse/handlers/search.ts dropped from 34 to 33 (an any was removed upstream). Prune the stale suppression to clear the 'No new ESLint warnings' gate on the release branch.
…ntract #9630 (976d670) intentionally changed the pre-dispatch skip behavior: when recordedAttempts === 0 (all targets filtered before any dispatch), handleComboChat now returns 503 ALL_TARGETS_SKIPPED instead of the misleading ALL_ACCOUNTS_INACTIVE. The two combo-routing-engine tests covering the 'every target skipped before execution' scenario still asserted the old code. Align both assertions to ALL_TARGETS_SKIPPED (the tests still verify the 503 + meaningful error code).
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up base-red fixes:
Refs #9679